Skip to content

[test] Add support to PrgEnv-nvidia in various tests #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jul 1, 2021
Merged

[test] Add support to PrgEnv-nvidia in various tests #2024

merged 18 commits into from
Jul 1, 2021

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jun 21, 2021 •
edited
Loading

The following tests are updated:

libsci_resolve, hdf5, netcdf, kernel_latency, cpu_target, cuda_fortran, environ, openacc and opencl

@teojgo teojgo requested review from jgphpc, jjotero and victorusu June 21, 2021 11:58
@teojgo teojgo self-assigned this Jun 21, 2021
@pep8speaks
Copy link

pep8speaks commented Jun 21, 2021 •
edited
Loading

Hello @teojgo, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-07-01 13:07:11 UTC

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021 •
edited
Loading

Codecov Report

Merging #2024 (d1ae454) into master (ba1b53a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   87.53%   87.53%           
=======================================
  Files          50       50           
  Lines        8889     8889           
=======================================
  Hits         7781     7781           
  Misses       1108     1108

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba1b53a...d1ae454. Read the comment docs.

jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
jgphpc
jgphpc reviewed Jun 21, 2021
View reviewed changes
@jjotero jjotero self-requested a review June 22, 2021 10:21
ekouts
ekouts approved these changes Jun 24, 2021
View reviewed changes
Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but we should definitely change the title before merging

@jjotero
Copy link
Contributor

jjotero commented Jun 24, 2021

Some tests are still failing in Dom

@teojgo teojgo mentioned this pull request Jun 24, 2021
Closed
@teojgo teojgo changed the title [test] Test/manitart prg env nvidia [test] Add support to PrgEnv-nvidia in several tests Jun 25, 2021
@jgphpc jgphpc changed the title [test] Add support to PrgEnv-nvidia in several tests [test] Add support to PrgEnv-nvidia in libsci_resolve, hdf5, netcdf, kernel_latency, cpu_target, cuda_fortran, environ, openacc and opencl checks Jun 28, 2021
@teojgo teojgo mentioned this pull request Jun 28, 2021
Closed
@teojgo
Copy link
Contributor Author

teojgo commented Jun 28, 2021

@jenkins-cscs retry all

@teojgo teojgo changed the title [test] Add support to PrgEnv-nvidia in libsci_resolve, hdf5, netcdf, kernel_latency, cpu_target, cuda_fortran, environ, openacc and opencl checks [test] Add support to PrgEnv-nvidia in various tests Jun 28, 2021
@teojgo teojgo mentioned this pull request Jun 28, 2021
Closed
@teojgo teojgo mentioned this pull request Jun 30, 2021
Closed
@teojgo
Copy link
Contributor Author

teojgo commented Jul 1, 2021

@jenkins-cscs retry daint

@jjotero
Copy link
Contributor

jjotero commented Jul 1, 2021

@teojgo There are still some PEP complaints

@teojgo
Copy link
Contributor Author

teojgo commented Jul 1, 2021

@teojgo There are still some PEP complaints

Wow, I have missed it. I am updating now.

@jjotero jjotero merged commit 8ec5098 into reframe-hpc:master Jul 1, 2021
@teojgo teojgo deleted the test/manitart_PrgEnv_nvidia branch August 13, 2021 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekouts ekouts ekouts approved these changes

@victorusu victorusu Awaiting requested review from victorusu

+2 more reviewers

@jgphpc jgphpc jgphpc approved these changes

@jjotero jjotero jjotero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@teojgo teojgo

Labels

prio: normal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@teojgo @pep8speaks @codecov-commenter @jjotero @jgphpc @ekouts