[feat] Make the @required_version decorator a class definition parameter

[ekouts]

Closes #1797.
I liked a bit more the argument option, than the built-in syntax, but we can change it. The new syntax is:

class BaseFoo(rfm.RegressionTest, require_version=['x.x.x', '>y.y.y']):
   ...

@rfm.simple_test
class Foo(BaseFoo):
   ...

Foo and all descendants will inherit the required versions, unless they specify require_version again.

[codecov-commenter]

Codecov Report

Merging #2046 (b3c4697) into master (4f3d906) will decrease coverage by 0.01%.
The diff coverage is 70.00%.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
- Coverage   86.76%   86.74%   -0.02%     
==========================================
  Files          52       52              
  Lines        9261     9271      +10     
==========================================
+ Hits         8035     8042       +7     
- Misses       1226     1229       +3     

Impacted Files	Coverage Δ
reframe/core/decorators.py	64.81% <66.66%> (+0.10%)	⬆️
reframe/core/pipeline.py	91.40% <80.00%> (-0.12%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f3d906...b3c4697. Read the comment docs.

[jjotero]

Just a small comment on the warning message. The rest looks good.

[pep8speaks]

Hello @ekouts, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-07-14 20:02:07 UTC

[jjotero]

We need to document these arguments in the manuals. I think that the best place is by adding the required_version (and pin_prefix and special) in the docstring of the RegressionTest base class.

[jjotero]

Another thing that just crossed my mind is that we should probably be consistent with how we name the class arguments. For example, pin_prefix indicates an action and required_version does not. Changing this arg to require_version would make this naming consistent, I think.

[vkarak]

I agree with @jjotero that we should find a proper location to document the class arguments. The natural place would be when documenting the RegressionTest class, but I don't know how we can inject in the documentation the arguments of the __init_subclass__.

[ekouts]

The documentation of the parameters is not ideal. Besides the signature of the RegressionTest, the documentation of the parameters doesn't appear exactly right.

The second format of require_version has some grey background and the description ("is a list of ReFrame version...") starts from the next line

[vkarak]

I have a couple of minor comments. I will have a look at the formatting problem you mentioned and I'll try to fix them too.