Skip to content

[bugfix] Handle None in Decimal conversion of junit report #2098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2021
Merged

[bugfix] Handle None in Decimal conversion of junit report #2098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
848ad3a
Handle `None` in `Decimal` conversion of junit report
Jul 27, 2021
b66240b
Address PR comments
Jul 29, 2021
b833a1e
Merge branch 'master' into bugfix/decimal_conversion_none_junit
Jul 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion reframe/frontend/runreport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def junit_xml_report(json_report):
# XSD schema does not like the exponential format and since
# we do not want to impose a fixed width, we pass it to
# `Decimal` to format it automatically.
'time': str(decimal.Decimal(tc['time_total'])),
'time': str(decimal.Decimal(tc['time_total'] or 0)),
}
)
if tc['result'] == 'failure':
Expand Down
4 changes: 4 additions & 0 deletions unittests/test_policies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ def test_runall(make_runner, make_cases, common_exec_ctx, tmp_path):
with open(report_file, 'w') as fp:
jsonext.dump(report, fp)

# We explicitly set `time_total` to `None` in the last test case, in order
# to test the proper handling of `None`.`
report['runs'][0]['testcases'][-1]['time_total'] = None

# Validate the junit report
xml_report = runreport.junit_xml_report(report)
_validate_junit_report(xml_report)
Expand Down