-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Refactor test registry #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @jjotero, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-08-12 17:58:24 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2119 +/- ##
==========================================
- Coverage 86.26% 85.96% -0.31%
==========================================
Files 53 53
Lines 9313 9355 +42
==========================================
+ Hits 8034 8042 +8
- Misses 1279 1313 +34
Continue to review full report at Codecov.
|
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Just a couple of minor comments.
The test registry is now a class that the loader can interact with. This
TestRegistryclass has a public member functioninstantiate_allwhich is equivalent to_rfm_gettests()in the previous implementation. This should give the loader far more control over the test instantiation and simplify the implementation of #2117.However, the
parameterized_testdecorator deals with the construction arguments in a different way and it's incompatible with this new registry. In any case, since this decorator is deprecated, we can keep the current test registry as a "legacy_registry" which is only used by tests decorated asparameterized_test.Similarly, the deprecated
require_versiondecorator also complicates things slightly, forcing theTestRegistryclass to account for the tests to be skipped. All this extra logic can be trimmed out once therequire_versiondecorator is dropped.