Skip to content

Conversation

@jjotero
Copy link
Contributor

@jjotero jjotero commented Aug 12, 2021

Closes #2067. This issue proposed that all hooks should be executed in the test's stagedir, but this cannot be generalised to all the pipeline stages (this could never apply to the init, setup and cleanup stages). Thus, instead it has been decided that this information is added in the docs, alongside a pseudo-example on how to change the working directory from the hook itself.

This PR also includes other minor improvements across the whole builtins section.

@jjotero jjotero added this to the ReFrame Sprint 21.08.1 milestone Aug 12, 2021
@jjotero jjotero requested review from teojgo, victorusu and vkarak August 12, 2021 15:14
@jjotero jjotero self-assigned this Aug 12, 2021
@jjotero jjotero changed the title [doc] Improve builtins section in the docs [doc] Improve builtins documentation Aug 12, 2021
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm just a minor comment.

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #2128 (a589dc7) into master (b5cae2d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2128   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          53       53           
  Lines        9362     9362           
=======================================
  Hits         8049     8049           
  Misses       1313     1313           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cae2d...a589dc7. Read the comment docs.

@vkarak vkarak changed the title [doc] Improve builtins documentation [doc] Improve documentation of built-ins Aug 18, 2021
@vkarak vkarak merged commit 91d5797 into reframe-hpc:master Aug 18, 2021
@jjotero jjotero deleted the docs/hooks branch August 19, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run all hooks in the test's stage directory

4 participants