-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Add support for the OAR scheduler #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Add support for the OAR scheduler #2129
Conversation
|
Can I test this patch? |
|
Ok to test |
Codecov Report
@@ Coverage Diff @@
## master #2129 +/- ##
==========================================
- Coverage 85.97% 85.53% -0.44%
==========================================
Files 54 55 +1
Lines 9651 9743 +92
==========================================
+ Hits 8297 8334 +37
- Misses 1354 1409 +55
Continue to review full report at Codecov.
|
…ture/oar-scheduler Merge with upstream master
|
@jenkins-cscs retry all |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mahendrapaipuri for your PR I cannot test the backend, so my comments are related to the code itself.
|
We would also need an entry in the documentation. |
Added an entry in the documentation. I added a line about CI image as well. I am sorry that I forgot to push that change in that previous PR. |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes broke the unit tests for test_prepare[oar]:
E assert {'#DW jobdw capacity=100GB',\n '#DW stage_in source=/foo',\n '#OAR --gres=gpu:4',\n '#OAR -E '\n '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.err',\n '#OAR -O '\n '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.out',\n '#OAR -l /host=8/core=2,walltime=0:5:0#OAR --account=spam',\n '#OAR -n "testjob"'} == {'#DW jobdw capacity=100GB',\n '#DW stage_in source=/foo',\n '#OAR --account=spam',\n '#OAR --gres=gpu:4',\n '#OAR -E '\n '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.err',\n '#OAR -O '\n '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.out',\n '#OAR -l /host=8/core=2,walltime=0:5:0',\n '#OAR -n "testjob"'}
E Extra items in the left set:
E '#OAR -l /host=8/core=2,walltime=0:5:0#OAR --account=spam'
E Extra items in the right set:
E '#OAR -l /host=8/core=2,walltime=0:5:0'
E '#OAR --account=spam'
E Full diff:
E {
E '#DW jobdw capacity=100GB',
E '#DW stage_in source=/foo',
E - '#OAR --account=spam',
E '#OAR --gres=gpu:4',
E '#OAR -E '
E '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.err',
E '#OAR -O '
E '/private/var/folders/h7/k7cgrdl13r996m4dmsvjq7v80000gp/T/pytest-of-karakasv/pytest-111/test_prepare_oar_0/job.out',
E - '#OAR -l /host=8/core=2,walltime=0:5:0',
E + '#OAR -l /host=8/core=2,walltime=0:5:0#OAR --account=spam',
E ? +++++++++++++++++++
E '#OAR -n "testjob"',
E }
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm now. I fixed the unit tests.
|
Thanks @vkarak for fixing unit tests. |
This PR adds support to a minimal OAR backend scheduler.
Fixes #2124.