Skip to content

Conversation

@hurricane642
Copy link
Contributor

This is a continuation of #2084, devoted exclusively to the LAMMPS test. A new file nve.py has been added, introducing the main class for the LAMMPS test, as well as the CSCS tests inherited from it.

@pep8speaks
Copy link

pep8speaks commented Sep 9, 2021

Hello @hurricane642, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-09-09 16:07:50 UTC

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@teojgo
Copy link
Contributor

teojgo commented Sep 9, 2021

Ok to test

@codecov-commenter
Copy link

Codecov Report

Merging #2175 (2876c2e) into master (eda1667) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2175      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.02%     
==========================================
  Files          53       53              
  Lines        9571     9557      -14     
==========================================
- Hits         8259     8249      -10     
+ Misses       1312     1308       -4     
Impacted Files Coverage Δ
reframe/utility/osext.py 84.71% <0.00%> (ø)
reframe/frontend/autodetect.py 62.41% <0.00%> (+0.54%) ⬆️
reframe/core/systems.py 89.38% <0.00%> (+0.62%) ⬆️
reframe/utility/jsonext.py 86.04% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda1667...2876c2e. Read the comment docs.

@victorusu
Copy link
Contributor

@jenkins-cscs retry all

@vkarak vkarak added this to the ReFrame Sprint 21.09.2 milestone Sep 28, 2021
@vkarak vkarak changed the title [test] Add generic LAMMPS check for the cscs-supported apps into hpctestlib/apps [testlib] Add generic LAMMPS check for the cscs-supported apps into hpctestlib/apps Nov 9, 2021
@vkarak vkarak removed this from the ReFrame sprint 21.11.2 milestone Nov 30, 2021
@vkarak
Copy link
Contributor

vkarak commented Dec 14, 2021

Closing this PR.

@vkarak vkarak closed this Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants