Skip to content

Conversation

@hurricane642
Copy link
Contributor

This is a continuation of #2084, devoted exclusively to the VASP test. A new file base_check.py has been added, introducing the main class for the VASP test, as well as the CSCS tests inherited from it.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@codecov-commenter
Copy link

Codecov Report

Merging #2180 (38ba697) into master (eda1667) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 38ba697 differs from pull request most recent head 11495d8. Consider uploading reports for the commit 11495d8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2180      +/-   ##
==========================================
+ Coverage   86.29%   86.31%   +0.02%     
==========================================
  Files          53       53              
  Lines        9571     9557      -14     
==========================================
- Hits         8259     8249      -10     
+ Misses       1312     1308       -4     
Impacted Files Coverage Δ
reframe/utility/osext.py 84.71% <0.00%> (ø)
reframe/frontend/autodetect.py 62.41% <0.00%> (+0.54%) ⬆️
reframe/core/systems.py 89.38% <0.00%> (+0.62%) ⬆️
reframe/utility/jsonext.py 86.04% <0.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eda1667...11495d8. Read the comment docs.

@vkarak vkarak added this to the ReFrame Sprint 21.09.2 milestone Sep 28, 2021
@vkarak vkarak removed this from the ReFrame Sprint 21.09.2 milestone Oct 13, 2021
@vkarak vkarak changed the title [test] Add generic VASP check for the cscs-supported apps into hpctestlib/apps [testlib] Add generic VASP check for the cscs-supported apps into hpctestlib/apps Nov 9, 2021
@vkarak vkarak added this to the ReFrame sprint 21.11.2 milestone Nov 16, 2021
@vkarak vkarak removed this from the ReFrame sprint 21.11.2 milestone Nov 25, 2021
@vkarak
Copy link
Contributor

vkarak commented Nov 30, 2021

This still needs substantial work, so I'm closing the PR due to time constraints. It will be added to the library at a later time.

@vkarak vkarak closed this Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants