[testlib] Add PyTorch library test and base CSCS test on top of it #2183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @hurricane642, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-11-30 20:47:21 UTC |
Collaborator
|
Can I test this patch? |
vkarak
changed the title
vkarak
requested changes
Nov 29, 2021
Codecov Report
@@ Coverage Diff @@
## master #2183 +/- ##
=======================================
Coverage 86.12% 86.12%
=======================================
Files 56 56
Lines 10208 10208
=======================================
Hits 8792 8792
Misses 1416 1416 Continue to review full report at Codecov.
|
vkarak
requested changes
Nov 30, 2021
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Just a couple of minor comments still.
vkarak
approved these changes
Nov 30, 2021
Contributor
|
ok to test |
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work on the test library. This PR work has been done with PyTorch tests. A new file base_check.py has been added, introducing the main class for the PyTorch test, as well as the CSCS tests inherited from it.