Skip to content

Conversation

@hurricane642
Copy link
Contributor

This is a continuation of the work on the test library. This PR work has been done with Numpy tests. A new file base_check.py has been added, introducing the main class for the Numpy test, as well as the CSCS tests inherited from it.

@pep8speaks
Copy link

pep8speaks commented Sep 9, 2021

Hello @hurricane642, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated at 2021-10-13 20:01:15 UTC

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@teojgo
Copy link
Contributor

teojgo commented Sep 10, 2021

Ok to test

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021

Codecov Report

Merging #2184 (c8f4033) into master (af7adff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2184   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          55       55           
  Lines        9746     9746           
=======================================
  Hits         8337     8337           
  Misses       1409     1409           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af7adff...c8f4033. Read the comment docs.

@vkarak vkarak added this to the ReFrame Sprint 21.09.2 milestone Sep 28, 2021
@teojgo teojgo self-assigned this Oct 6, 2021
@vkarak vkarak added this to the ReFrame Sprint 21.09.2 milestone Oct 13, 2021
@vkarak
Copy link
Contributor

vkarak commented Oct 13, 2021

I did the following changes:

  • Removed the documentation for executable etc. I don't think it makes sense to document them, unless they are required.
  • I moved the test in the library under hpctestlib/python
  • I documented the performance functions and used s as units.

@vkarak vkarak changed the title [test] Add generic Python check for the cscs-supported apps into hpctestlib/apps [test] Add Python NumPy library check and build CSCS test on top of it Oct 13, 2021
@vkarak vkarak merged commit 747254d into reframe-hpc:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants