Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Sep 24, 2021

Close #2135

@rsarm rsarm added this to the ReFrame Sprint 21.09.2 milestone Sep 24, 2021
@rsarm rsarm requested review from teojgo and vkarak September 24, 2021 14:29
@rsarm rsarm self-assigned this Sep 24, 2021
@rsarm
Copy link
Contributor Author

rsarm commented Sep 24, 2021

@mahendrapaipuri could you have a look?

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2021

Codecov Report

Merging #2201 (6f7c4ca) into master (9804e1c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2201   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          55       55           
  Lines        9745     9746    +1     
=======================================
+ Hits         8336     8337    +1     
  Misses       1409     1409           
Impacted Files Coverage Δ
reframe/utility/__init__.py 92.76% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9804e1c...6f7c4ca. Read the comment docs.

@mahendrapaipuri
Copy link
Contributor

@rsarm Looks good. Just a minor suggestion. Do you think moving

rfm_root = os.path.realpath(os.path.join(os.path.dirname(__file__), '../..'))

into a new function like get_rfm_root makes sense? This makes it more modular and reusable if we ever need ReFrame root directory in further developments.

@rsarm
Copy link
Contributor Author

rsarm commented Sep 27, 2021

What about replacing by here reframe.INSTALL_PREFIX too?

@vkarak vkarak changed the title [bugfix] Fix issues when ReFrame root directory is not in sys.path[0] [bugfix] Fix --restore-session failure when ReFrame root directory is not in sys.path[0] Sep 28, 2021
@vkarak vkarak merged commit 021a055 into reframe-hpc:master Sep 28, 2021
@rsarm rsarm deleted the relative-syspath branch February 3, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors when ReFrame root directory is not first path in sys.path

5 participants