[bugfix] Fix error when cache associativity information is not available by sysctl
#2206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2206 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 55 55
Lines 9746 9746
=======================================
Hits 8337 8337
Misses 1409 1409
Continue to review full report at Codecov.
|
rsarm
approved these changes
Sep 30, 2021
teojgo
approved these changes
Sep 30, 2021
vkarak
changed the title
sysctl
vkarak
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2202 .
In the sysctl output from @rsarm's laptop I could not find the information for the cache associativity. So in order to fix the bug in the unittest I made the
sysctlcommand more generic (to avoid theSpawnedProcessErrorexception).We don't give a warning for every item of the processor information that we cannot detect because it would unnecessarily complicate the
--detect-host-topologyoption, since it's supposed to print only the json object.