Skip to content

[feat] Use fully qualified domain names when retrieving hostnames #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2021
Merged

[feat] Use fully qualified domain names when retrieving hostnames #2216

merged 1 commit into from
Oct 8, 2021

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Oct 8, 2021

Close #2212

@rsarm rsarm added this to the ReFrame Sprint 21.09.2 milestone Oct 8, 2021
@rsarm rsarm requested review from jjotero and vkarak October 8, 2021 08:31
@rsarm rsarm self-assigned this Oct 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021 •
edited
Loading

Codecov Report

Merging #2216 (6641d23) into master (3abb6db) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2216   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          55       55           
  Lines        9746     9746           
=======================================
  Hits         8337     8337           
  Misses       1409     1409
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.31% <ø> (ø)
reframe/core/config.py 91.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abb6db...6641d23. Read the comment docs.

jjotero
jjotero approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@jjotero jjotero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak changed the title [feat] Get hostname using getfqdn() instead of gethostname() [feat] Use fully qualified domain names for hostnames Oct 8, 2021
@vkarak vkarak changed the title [feat] Use fully qualified domain names for hostnames [feat] Use fully qualified domain names when retrieving hostnames Oct 8, 2021
@vkarak vkarak merged commit af7adff into reframe-hpc:master Oct 8, 2021
@rsarm rsarm mentioned this pull request Feb 22, 2022
Closed
@rsarm rsarm deleted the hostname-fqdn branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

+1 more reviewer

@jjotero jjotero jjotero approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rsarm rsarm

Labels

prio: normal request for enhancement

Projects

None yet

Milestone

ReFrame Sprint 21.09.2

Development

Successfully merging this pull request may close these issues.

Get hostname using getfqdn() instead of gethostname()

4 participants

@rsarm @codecov-commenter @vkarak @jjotero