Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Oct 15, 2021

Closes #2170

@rsarm
Copy link
Contributor Author

rsarm commented Oct 15, 2021

I'm nor sure here about the name of the option exclude-tags. And if we keep something like that, should we change --exclude to --exclude-names?

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #2223 (1281e6f) into master (081d922) will increase coverage by 0.00%.
The diff coverage is 85.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2223   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files          55       55           
  Lines        9747     9754    +7     
=======================================
+ Hits         8338     8344    +6     
- Misses       1409     1410    +1     
Impacted Files Coverage Δ
reframe/frontend/cli.py 76.30% <66.66%> (-0.06%) ⬇️
reframe/frontend/filters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081d922...1281e6f. Read the comment docs.

Copy link
Contributor

@ekouts ekouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. I have a small comment but feel free to leave as it is.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comment of @ekouts and I have another minor one.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about this, please add the relevant entry in the documentation (man page)

@vkarak
Copy link
Contributor

vkarak commented Oct 25, 2021

I renamed the option to --exclude-tag and rearranged the order in which they are defined and documented.

@vkarak vkarak changed the title [feat] Add option to exclude tests with a specific tag [feat] Add command line option to exclude tests with a specific tag Oct 25, 2021
@vkarak vkarak merged commit 4ab88be into reframe-hpc:master Oct 25, 2021
@rsarm rsarm deleted the exclude-tags branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to exclude tests with a specific tag

4 participants