Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Nov 12, 2021

This is the complete analogous to the extras in the definition of the partitions. Users can now define an extras attribute in their environment configuration, which allows them to attach arbitrary properties to environments. These are accessible inside a test through the extras attribute of the current_environ.

Fixes #1973.
Fixes #2230.

@vkarak vkarak added this to the ReFrame sprint 21.11.1 milestone Nov 12, 2021
@vkarak vkarak requested review from ekouts and rsarm November 12, 2021 17:52
@vkarak vkarak self-assigned this Nov 12, 2021
@vkarak
Copy link
Contributor Author

vkarak commented Nov 16, 2021

@jenkins-cscs retry dom

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #2265 (a1c0e48) into master (81f1415) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a1c0e48 differs from pull request most recent head 3e524f8. Consider uploading reports for the commit 3e524f8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2265   +/-   ##
=======================================
  Coverage   86.12%   86.13%           
=======================================
  Files          56       56           
  Lines       10198    10202    +4     
=======================================
+ Hits         8783     8787    +4     
  Misses       1415     1415           
Impacted Files Coverage Δ
reframe/core/systems.py 89.47% <ø> (ø)
reframe/core/environments.py 97.19% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e0d447...3e524f8. Read the comment docs.

@vkarak vkarak merged commit 82a6bc8 into reframe-hpc:master Nov 16, 2021
@vkarak vkarak deleted the feat/env-extras branch November 16, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement: Custom user fields in environments Add metadata to environments definition

5 participants