[feat] Add a utility function to skip tests that have no topology information #2267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vkarak, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated at 2021-11-15 16:56:43 UTC |
Codecov Report
@@ Coverage Diff @@
## master #2267 +/- ##
=======================================
Coverage 86.11% 86.12%
=======================================
Files 56 56
Lines 10190 10196 +6
=======================================
+ Hits 8775 8781 +6
Misses 1415 1415
Continue to review full report at Codecov.
|
teojgo
requested changes
Nov 15, 2021
teojgo
approved these changes
Nov 16, 2021
ekouts
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is quite useful with the topology autodetection, since it should be called the the first time that the topology is requested in a test. Otherwise, users would have to write a post-setup hook doing the same thing. I am not adding for the moment an equivalent function for the device autodetection, because I would like to first see the usage scenarios in practice.