Skip to content

[feat] Support passing arbitrary options to git clone in the git_clone() utility function #2279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 23, 2021
Merged

[feat] Support passing arbitrary options to git clone in the git_clone() utility function #2279

merged 4 commits into from
Nov 23, 2021

Conversation

@mahendrapaipuri
Copy link
Contributor

@mahendrapaipuri mahendrapaipuri commented Nov 22, 2021

Closes #2278

@mahendrapaipuri mahendrapaipuri changed the title Support options to git_clone function [feat] Support options to git_clone function Nov 22, 2021
@jenkins-cscs
Copy link
Collaborator

jenkins-cscs commented Nov 22, 2021

Can I test this patch?

@teojgo teojgo requested review from teojgo and vkarak November 22, 2021 10:02
@teojgo teojgo assigned teojgo and mahendrapaipuri and unassigned teojgo Nov 22, 2021
@vkarak vkarak added this to the ReFrame sprint 21.11.2 milestone Nov 22, 2021
vkarak
vkarak requested changes Nov 22, 2021
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021 •
edited
Loading

Codecov Report

Merging #2279 (961fb35) into master (01579d9) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 961fb35 differs from pull request most recent head 3aa78f3. Consider uploading reports for the commit 3aa78f3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2279      +/-   ##
==========================================
- Coverage   86.13%   86.12%   -0.01%     
==========================================
  Files          56       56              
  Lines       10205    10206       +1     
==========================================
  Hits         8790     8790              
- Misses       1415     1416       +1
Impacted Files Coverage Δ
reframe/utility/osext.py 84.36% <33.33%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01579d9...3aa78f3. Read the comment docs.

@teojgo
Copy link
Contributor

teojgo commented Nov 22, 2021

Ok to test

@vkarak
Copy link
Contributor

vkarak commented Nov 22, 2021

ok to test

@vkarak vkarak changed the title [feat] Support options to git_clone function [feat] Support passing arbitrary options to git clone in the git_clone() utility function Nov 22, 2021
teojgo
teojgo requested changes Nov 22, 2021
View reviewed changes
@mahendrapaipuri
Update git_clone docstring
01e6da4 
Co-authored-by: Theofilos Manitaras <manitaras@cscs.ch>
@vkarak vkarak requested a review from teojgo November 22, 2021 12:31
victorusu
victorusu approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 746c4ea into reframe-hpc:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@victorusu victorusu victorusu approved these changes

@teojgo teojgo Awaiting requested review from teojgo

Assignees

@mahendrapaipuri mahendrapaipuri

Labels

enhancement prio: normal

Projects

None yet

Milestone

ReFrame sprint 21.11.2

Development

Successfully merging this pull request may close these issues.

Support options to osext.git_clone function

6 participants

@mahendrapaipuri @jenkins-cscs @codecov-commenter @teojgo @vkarak @victorusu