[feat] Improve OAR preamble commands #2318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a bug in OAR scheduler we had to give full path to stdout and stderr files and change working directory to stagedir in preamble commands. This issue has been fixed at upstream OAR and so we remove these unnecessary full paths in preamble
Collaborator
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #2318 +/- ##
==========================================
- Coverage 86.12% 86.12% -0.01%
==========================================
Files 56 56
Lines 10208 10207 -1
==========================================
- Hits 8792 8791 -1
Misses 1416 1416
Continue to review full report at Codecov.
|
vkarak
approved these changes
Dec 6, 2021
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in OAR scheduler we had to give full path to
stdoutandstderrfiles and change working directory tostagedirin preamble commands. This issue has been fixed at upstream OAR and so we remove these unnecessary full paths in preamble.