Skip to content

[bugfix] Add support for heterogeneous jobs in Slurm backend #2376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 13, 2022
Merged

[bugfix] Add support for heterogeneous jobs in Slurm backend #2376

merged 5 commits into from
Jan 13, 2022

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jan 12, 2022 •
edited
Loading

Fixes #2359

@teojgo teojgo added this to the ReFrame sprint 22.01.1 milestone Jan 12, 2022
@teojgo teojgo requested review from rsarm and vkarak January 12, 2022 10:38
@teojgo teojgo self-assigned this Jan 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022 •
edited
Loading

Codecov Report

Merging #2376 (98596f3) into master (1e211cf) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2376   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files          56       56           
  Lines       10225    10225           
=======================================
  Hits         8808     8808           
  Misses       1417     1417
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 52.43% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e211cf...98596f3. Read the comment docs.

vkarak
vkarak reviewed Jan 12, 2022
View reviewed changes
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way we can add a unit test for this?

@teojgo
Copy link
Contributor Author

teojgo commented Jan 13, 2022

Is there a way we can add a unit test for this?

Probably yes, like we do with https://github.com/eth-cscs/reframe/blob/f8dbad6e76ae9975473b99f888e98a52cbb43644/unittests/test_schedulers.py#L347

@vkarak vkarak changed the title [bugfix] Make Slurm polling aware of Heterogeneous Jobs [bugfix] Make Slurm backend aware of heterogeneous jobs Jan 13, 2022
@vkarak vkarak changed the title [bugfix] Make Slurm backend aware of heterogeneous jobs [bugfix] Add support for heterogeneous jobs in Slurm backend Jan 13, 2022
@vkarak vkarak merged commit a07a057 into reframe-hpc:master Jan 13, 2022
@teojgo teojgo deleted the bugfix/poll_hetjob_slurm branch March 3, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@rsarm rsarm Awaiting requested review from rsarm

Assignees

@teojgo teojgo

Labels

bugfix prio: normal

Projects

None yet

Milestone

ReFrame sprint 22.01.1

Development

Successfully merging this pull request may close these issues.

Heterogeneous job ids can't be matched by ReFrame's polling

3 participants

@teojgo @codecov-commenter @vkarak