Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Jan 19, 2022

Closes #2336

@rsarm rsarm added this to the ReFrame sprint 22.01.1 milestone Jan 19, 2022
@rsarm rsarm requested review from ekouts and vkarak January 19, 2022 10:15
@rsarm rsarm self-assigned this Jan 19, 2022
@rsarm rsarm marked this pull request as draft January 19, 2022 10:34
@rsarm rsarm marked this pull request as ready for review January 19, 2022 14:24
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2022

Codecov Report

Merging #2390 (b487095) into master (f02136b) will increase coverage by 0.27%.
The diff coverage is 100.00%.

❗ Current head b487095 differs from pull request most recent head 1c1c773. Consider uploading reports for the commit 1c1c773 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2390      +/-   ##
==========================================
+ Coverage   85.86%   86.13%   +0.27%     
==========================================
  Files          56       56              
  Lines       10270    10228      -42     
==========================================
- Hits         8818     8810       -8     
+ Misses       1452     1418      -34     
Impacted Files Coverage Δ
reframe/utility/__init__.py 92.64% <100.00%> (-0.12%) ⬇️
reframe/frontend/cli.py 76.42% <0.00%> (-0.09%) ⬇️
reframe/core/pipeline.py 92.83% <0.00%> (-0.06%) ⬇️
reframe/frontend/executors/__init__.py 98.29% <0.00%> (+0.78%) ⬆️
reframe/core/systems.py 89.47% <0.00%> (+1.31%) ⬆️
reframe/core/schedulers/local.py 96.63% <0.00%> (+3.36%) ⬆️
reframe/frontend/executors/policies.py 99.69% <0.00%> (+6.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02136b...1c1c773. Read the comment docs.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Just a couple of minor comments still.

@vkarak vkarak changed the title [bugfix] Improve mechanism for importing reframe tests [bugfix] Avoid conflicts with already loaded Python modules when loading ReFrame tests Jan 22, 2022
@vkarak vkarak merged commit bc280c5 into reframe-hpc:master Jan 22, 2022
@rsarm rsarm deleted the bugfix/import-with-hash branch February 3, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

using a test file named zlib.py never runs the test

4 participants