Skip to content

[feat] Stop execution with an error when a cli module fails to load #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 26, 2022
Merged

[feat] Stop execution with an error when a cli module fails to load #2603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b02144c
Stop execution with an error when `-m` fails
ekouts Sep 23, 2022
e6decec
Fix unittest
ekouts Sep 23, 2022
d625bdc
Merge branch 'master' of https://github.com/reframe-hpc/reframe into …
ekouts Sep 26, 2022
67db7c9
Change error message to debug
ekouts Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions reframe/frontend/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1240,11 +1240,12 @@ def module_unuse(*paths):
try:
rt.modules_system.load_module(**m, force=True)
except errors.EnvironError as e:
printer.warning(
f'could not load module {m["name"]!r} correctly; '
f'skipping...'
printer.error(
f'could not load module {m["name"]!r} correctly; rerun '
f'with -vv for more information'
)
printer.debug(str(e))
sys.exit(1)

options.flex_alloc_nodes = options.flex_alloc_nodes or 'idle'

Expand Down
2 changes: 1 addition & 1 deletion unittests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,7 @@ def test_unuse_module_path(run_reframe, user_exec_ctx):
ms.searchpath_remove(module_path)
assert "could not load module 'testmod_foo' correctly" in stdout
assert 'Traceback' not in stderr
assert returncode == 0
assert returncode == 1


def test_use_module_path(run_reframe, user_exec_ctx):
Expand Down