Skip to content

Conversation

@giordano
Copy link
Contributor

@giordano giordano commented Oct 3, 2022

No description provided.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@ekouts
Copy link
Contributor

ekouts commented Oct 3, 2022

Ok to test

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rephrased and expanded the note and made it also more visible. Lgtm now.

@vkarak vkarak changed the title [doc] Make it clear logical CPUs refer to threads [doc] Make it clear that logical CPUs refer to hardware threads Oct 3, 2022
@vkarak
Copy link
Contributor

vkarak commented Oct 3, 2022

ok to test

@codecov-commenter
Copy link

Codecov Report

Base: 86.26% // Head: 86.26% // No change to project coverage 👍

Coverage data is based on head (9c48ccd) compared to base (32da8eb).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2619   +/-   ##
=======================================
  Coverage   86.26%   86.26%           
=======================================
  Files          60       60           
  Lines       10967    10967           
=======================================
  Hits         9461     9461           
  Misses       1506     1506           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vkarak vkarak merged commit c595d65 into reframe-hpc:master Oct 4, 2022
@giordano giordano deleted the patch-1 branch October 4, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants