From dceb977b0d9d58ff73b83cb109c14457bdf3601c Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Wed, 19 Oct 2022 22:27:59 +0200 Subject: [PATCH 1/2] Change default value for `num_gpus_per_node` to `None` --- reframe/core/pipeline.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/reframe/core/pipeline.py b/reframe/core/pipeline.py index 06c3134d4b..52e2ba8d73 100644 --- a/reframe/core/pipeline.py +++ b/reframe/core/pipeline.py @@ -557,8 +557,11 @@ def pipeline_hooks(cls): #: :attr:`extra_resources` attribute. #: #: :type: integral - #: :default: ``0`` - num_gpus_per_node = variable(int, value=0, loggable=True) + #: :default: :const:`None` + #: + #: .. versionchanged:: 4.0.0 + #: The default value changed to :const:`None`. + num_gpus_per_node = variable(int, type(None), value=None, loggable=True) #: Number of CPUs per task required by this test. #: @@ -1890,7 +1893,7 @@ def _get_cp_env(): environs.insert(2, cp_env) # num_gpus_per_node is a managed resource - if self.num_gpus_per_node > 0: + if self.num_gpus_per_node: self.extra_resources.setdefault( '_rfm_gpu', {'num_gpus_per_node': self.num_gpus_per_node} ) From 833698a667c5c72db59df06c68e9f925b56f3ca7 Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Thu, 20 Oct 2022 21:12:59 +0200 Subject: [PATCH 2/2] Address PR comments --- reframe/core/pipeline.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reframe/core/pipeline.py b/reframe/core/pipeline.py index 52e2ba8d73..80b3fdd727 100644 --- a/reframe/core/pipeline.py +++ b/reframe/core/pipeline.py @@ -556,7 +556,7 @@ def pipeline_hooks(cls): #: For more information on test resources, have a look at the #: :attr:`extra_resources` attribute. #: - #: :type: integral + #: :type: integral or :const:`None` #: :default: :const:`None` #: #: .. versionchanged:: 4.0.0