Skip to content

[bugfix] Expand the Slurm nodelist using scontrol and not the builtin nodelist_expand() function #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2022
Merged

[bugfix] Expand the Slurm nodelist using scontrol and not the builtin nodelist_expand() function #2678

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
965fc6f
Expand nodelist with the scontrol utility
ekouts Nov 18, 2022
fe05d83
Remove unused import
ekouts Nov 18, 2022
6af68b2
Merge branch 'master' into bugfix_expand_nodelist
vkarak Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions reframe/core/schedulers/slurm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
JobBlockedError,
JobError,
JobSchedulerError)
from reframe.utility import nodelist_abbrev, nodelist_expand, seconds_to_hms
from reframe.utility import nodelist_abbrev, seconds_to_hms


def slurm_state_completed(state):
Expand Down Expand Up @@ -81,7 +81,10 @@ def __init__(self, *args, **kwargs):
def nodelist(self):
# Redefine nodelist so as to generate it from the nodespec
if self._nodelist is None and self._nodespec is not None:
self._nodelist = nodelist_expand(self._nodespec)
completed = osext.run_command(
f'scontrol show hostname {self._nodespec}', log=False
)
self._nodelist = completed.stdout.splitlines()

return self._nodelist

Expand Down