Skip to content

[testlib] Use the builtin validation option of OSU benchmarks to validate the results #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

[testlib] Use the builtin validation option of OSU benchmarks to validate the results #2679

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a746222
Add optional validation `-c` option to the OSU tests
mszpindler Oct 21, 2022
7f237b9
Make OSU builtin validation the default
vkarak Nov 16, 2022
4f40347
Merge branch 'master' into osu-with-builtin-validation
vkarak Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions hpctestlib/microbenchmarks/mpi/osu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ def setup_per_benchmark(self):
self.executable = bench.split('.')[-1]
self.executable_opts = ['-m', f'{self.message_size}',
'-x', f'{self.num_warmup_iters}',
'-i', f'{self.num_iters}']
'-i', f'{self.num_iters}', '-c']

if self.device_buffers != 'cpu':
self.executable_opts += ['-d', self.device_buffers]

Expand All @@ -161,7 +162,7 @@ def setup_per_benchmark(self):

@sanity_function
def validate_test(self):
return sn.assert_found(rf'^{self.message_size}', self.stdout)
return sn.assert_found(rf'^{self.message_size}.*Pass', self.stdout)

@deferrable
def _extract_metric(self):
Expand Down