Skip to content

Conversation

@ekouts
Copy link
Contributor

@ekouts ekouts commented Jan 25, 2023

We do something similar in case of BuildError, where we add the stderr in the message of the exception: https://github.com/reframe-hpc/reframe/blob/develop/reframe/core/exceptions.py#L164
I print stderr and stdout in statistics because we have checks at CSCS that raise their own SanityError (like this example) and I thought other people may be using it like this.
What do you think? Should I change the PR and go with the approach of BuildError?

Closes #2668 .

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Base: 86.61% // Head: 86.61% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (1ea48de) compared to base (12827d9).
Patch coverage: 85.71% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2762      +/-   ##
===========================================
- Coverage    86.61%   86.61%   -0.01%     
===========================================
  Files           60       60              
  Lines        11215    11235      +20     
===========================================
+ Hits          9714     9731      +17     
- Misses        1501     1504       +3     
Impacted Files Coverage Δ
reframe/frontend/statistics.py 95.18% <85.71%> (-0.89%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that it's better to add in the failure report instead of bloating the SanityError.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 0fbffce into reframe-hpc:develop Jan 26, 2023
@ekouts ekouts deleted the feat/sanity_failures branch March 13, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Print always the first lines of stderr (and stdout) in case of sanity failures

3 participants