[feat] Allow setting nested mapping types using the -S option
#2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can I test this patch? |
giordano
commented
May 2, 2023
Contributor
|
What would be the syntax for setting a nested dict from the command line? Could you give an example? |
Contributor
Author
|
Something like |
vkarak
reviewed
May 5, 2023
giordano
force-pushed
the
mg/convert-json
branch
from
3488a0e to
95a9cfd
Compare
The advantage is that we can automatically convert nested mappings, like for example the `extra_resources` attribute, which can thus be set from the command line.
giordano
force-pushed
the
mg/convert-json
branch
from
95a9cfd to
5454737
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2876 +/- ##
========================================
Coverage 87.35% 87.35%
========================================
Files 60 60
Lines 11676 11680 +4
========================================
+ Hits 10199 10203 +4
Misses 1477 1477
☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Bump 🙂 |
vkarak
requested changes
Jul 3, 2023
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Lgtm; I've done a couple of style fixes. We'd need also to update the docs of the -S option.
vkarak
approved these changes
Jul 3, 2023
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
I updated the docs; it's fine now.
vkarak
changed the title
json module-S option
Contributor
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage is that we can automatically convert nested mappings, like for example the
extra_resourcesattribute, which can thus be set from the command line.This is the kind of change I'd like to propose to fix #2868. If this is deemed acceptable, I'll add some tests.