-
Notifications
You must be signed in to change notification settings - Fork 117
[feat] Combine perflogs for parameterised tests #2882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vkarak
merged 5 commits into
reframe-hpc:develop
from
vkarak:feat/combine-param-test-logs
Jun 14, 2023
Merged
[feat] Combine perflogs for parameterised tests #2882
vkarak
merged 5 commits into
reframe-hpc:develop
from
vkarak:feat/combine-param-test-logs
Jun 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - New special log format specifier that dumps all the loggable test attributes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2882 +/- ##
========================================
Coverage 86.97% 86.98%
========================================
Files 60 60
Lines 11596 11627 +31
========================================
+ Hits 10086 10114 +28
- Misses 1510 1513 +3
☔ View full report in Codecov by Sentry. |
ekouts
requested changes
Jun 12, 2023
Contributor
ekouts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, just some small comments.
Co-authored-by: Eirini Koutsaniti <eirini.koutsaniti@cscs.ch>
ekouts
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the following:
%(check_#ALL)sis added. If this is found in the log format, it will be replaced by all the loggable%(check_<attr>)s.ignore_keysconfiguration parameter is added to the filelog log handler that allows users to ignore certain test attributes during logging. The builtin configuration already puts several attributes in that list in order to save space.|as the,may conflict with the loggedenv_varsandextra_resources. Users using the%(check_#ALL)sspecifier should pay attention to the delimiter used in their format.Todos
Closes #2591.