Add a knob for controlling the 'sacct'/'squeue' ratio in Slurm 'sacct' backend #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reduce the `squeue` rate by introducing the constant `SACCT_SQUEUE_RATIO`. * Fix some warnings regarding regexes.
victorusu
approved these changes
May 28, 2018
| 'ReqNodeNotAvail', # Inaccurate SLURM doc | ||
| 'QOSUsageThreshold'] | ||
| self._is_cancelling = False | ||
| self._update_state_count = 0 |
vkarak
requested changes
May 28, 2018
reframe/core/schedulers/slurm.py
Outdated
| self._state = SlurmJobState(state_match.group('state')) | ||
| self._cancel_if_blocked() | ||
|
|
||
| if self._update_state_count == SACCT_SQUEUE_RATIO: |
Contributor
There was a problem hiding this comment.
I would simply do a modulo operation here:
if not self._update_state_count % SACCT_SQUEUE_RATIO:
self._cancel_if_blocked()
reframe/core/schedulers/slurm.py
Outdated
| SLURM_JOB_TIMEOUT = SlurmJobState('TIMEOUT') | ||
|
|
||
| # Number of _update_state calls per which _cancel_if_blocked is called | ||
| SACCT_SQUEUE_RATIO = 20 |
Contributor
There was a problem hiding this comment.
I think this constant should be defined inside the SlurmJob class as class attribute, since it is very specific to this implementation.
Contributor
There was a problem hiding this comment.
@victorusu Should we start with 10 and see if ops are happy?
reframe/core/schedulers/slurm.py
Outdated
| SLURM_JOB_SUSPENDED = SlurmJobState('SUSPENDED') | ||
| SLURM_JOB_TIMEOUT = SlurmJobState('TIMEOUT') | ||
|
|
||
| # Number of _update_state calls per which _cancel_if_blocked is called |
Contributor
There was a problem hiding this comment.
I don't like this comment very much; it contradicts with the name of the variable. If we use the SACCT_SQUEUE_RATIO as a name, I'd like to see a comment describing the rationale behind this instead, because what this variable controls is obvious from its name.
vkarak
changed the title
vkarak
changed the title
vkarak
approved these changes
May 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the
squeuerate by introducing the constantSACCT_SQUEUE_RATIO.Fix some warnings regarding regexes.
Fixes #283