From 2cea4aa123bc6df6ac391b74341dc3f2cc8cbe18 Mon Sep 17 00:00:00 2001 From: Vasileios Karakasis Date: Thu, 30 Nov 2023 23:08:12 +0100 Subject: [PATCH] Do not pass stdout/stderr options to `srunalloc` launcher --- reframe/core/launchers/mpi.py | 6 ------ unittests/test_launchers.py | 4 ---- 2 files changed, 10 deletions(-) diff --git a/reframe/core/launchers/mpi.py b/reframe/core/launchers/mpi.py index 9bb19ba305..fce5bf8471 100644 --- a/reframe/core/launchers/mpi.py +++ b/reframe/core/launchers/mpi.py @@ -126,12 +126,6 @@ def command(self, job): h, m, s = seconds_to_hms(job.time_limit) ret += ['--time=%d:%d:%d' % (h, m, s)] - if job.stdout: - ret += ['--output=%s' % job.stdout] - - if job.stderr: - ret += ['--error=%s' % job.stderr] - if job.num_tasks: ret += ['--ntasks=%s' % str(job.num_tasks)] diff --git a/unittests/test_launchers.py b/unittests/test_launchers.py index 6a59a4dbea..1ea59d951e 100644 --- a/unittests/test_launchers.py +++ b/unittests/test_launchers.py @@ -130,8 +130,6 @@ def test_run_command(job): assert command == ('srun ' '--job-name=fake_job ' '--time=0:10:0 ' - '--output=fake_stdout ' - '--error=fake_stderr ' '--ntasks=4 ' '--ntasks-per-node=2 ' '--ntasks-per-core=1 ' @@ -177,8 +175,6 @@ def test_run_command_minimal(minimal_job): elif launcher_name == 'srunalloc': assert command == ('srun ' '--job-name=fake_job ' - '--output=fake_job.out ' - '--error=fake_job.err ' '--ntasks=1 ' '--foo') elif launcher_name == 'ssh':