Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Dec 4, 2023

Closes #3019.

@codecov
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67d07ff) 86.70% compared to head (f6e583d) 86.70%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3070   +/-   ##
========================================
  Coverage    86.70%   86.70%           
========================================
  Files           61       61           
  Lines        12002    12006    +4     
========================================
+ Hits         10406    10410    +4     
  Misses        1596     1596           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vkarak vkarak merged commit 06f3e8a into reframe-hpc:develop Dec 5, 2023
@vkarak vkarak deleted the enhancement/invalid-mode-error branch December 5, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Passing an invalid mode should issue an error not a warning

2 participants