Skip to content

[feat] Issue an error when invoking an invalid mode #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023
Merged

[feat] Issue an error when invoking an invalid mode #3070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion reframe/frontend/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ def restrict_logging():
if options.mode:
mode = site_config.get(f'modes/@{options.mode}')
if mode is None:
printer.warning(f'invalid mode: {options.mode!r}; ignoring...')
raise errors.ReframeError(f'invalid mode: {options.mode!r}')
else:
mode_args = site_config.get(f'modes/@{options.mode}/options')

Expand All @@ -811,6 +811,10 @@ def restrict_logging():
printer.error(f'failed to load configuration: {e}')
printer.info(logfiles_message())
sys.exit(1)
except errors.ReframeError as e:
printer.error(str(e))
printer.info(logfiles_message())
sys.exit(1)

printer.colorize = site_config.get('general/0/colorize')
if not restrict_logging():
Expand Down
5 changes: 3 additions & 2 deletions unittests/test_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,7 @@ def test_execution_modes(run_reframe, run_action):
assert 'Ran 1/1 test case' in stdout


def test_invalid_mode_warning(run_reframe):
def test_invalid_mode_error(run_reframe):
mode = 'invalid'
returncode, stdout, stderr = run_reframe(
action='list',
Expand All @@ -538,7 +538,8 @@ def test_invalid_mode_warning(run_reframe):
)
assert 'Traceback' not in stdout
assert 'Traceback' not in stderr
assert f'invalid mode: {mode!r}; ignoring' in stdout
assert returncode == 1
assert f'ERROR: invalid mode: {mode!r}' in stdout


def test_timestamp_option(run_reframe):
Expand Down