[bugfix] Do not ignore the use_login_shell configuration option when generation the auto-detection script
#3094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekouts
changed the title
use_login_shell configuration value in the autodetection scriptuse_login_shell option from the configuration in the autodetection script
ekouts
changed the title
use_login_shell option from the configuration in the autodetection scriptuse_login_shell option from the configuration in the autodetection script
teojgo
approved these changes
Jan 12, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3094 +/- ##
==========================================
- Coverage 86.63% 86.63% -0.01%
==========================================
Files 61 61
Lines 12041 12042 +1
==========================================
Hits 10432 10432
- Misses 1609 1610 +1 ☔ View full report in Codecov by Sentry. |
Contributor
|
Could we add a unit test for this? |
vkarak
approved these changes
Jan 31, 2024
vkarak
changed the title
use_login_shell option from the configuration in the autodetection scriptuse_login_shell configuration option when generation the auto-detection script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful for the firecrest scheduler, but probably also for other schedulers.