Skip to content

[bugfix] Do not ignore the use_login_shell configuration option when generation the auto-detection script #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 4, 2024
Merged

[bugfix] Do not ignore the use_login_shell configuration option when generation the auto-detection script #3094

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d23a13b
Take into account `use_login_shell` value in autodetection script
ekouts Jan 12, 2024
465b617
Remove duplication
vkarak Jan 31, 2024
c48a32a
Coding style fixes
vkarak Jan 31, 2024
3a30e58
Merge branch 'master' into bugfix/login_shell_in_autodetect
vkarak Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions reframe/frontend/autodetect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,12 +131,14 @@ def _is_part_local(part):


def _remote_detect(part):
use_login_shell = runtime.runtime().get_option('general/0/use_login_shell')

def _emit_script_for_source(job, env):
commands = [
'./bootstrap.sh',
'./bin/reframe --detect-host-topology=topo.json'
]
job.prepare(commands, env, trap_errors=True)
job.prepare(commands, env, trap_errors=True, login=use_login_shell)

def _emit_script_for_pip(job, env):
commands = [
Expand All @@ -147,7 +149,7 @@ def _emit_script_for_pip(job, env):
'reframe --detect-host-topology=topo.json',
'deactivate'
]
job.prepare(commands, env, trap_errors=True)
job.prepare(commands, env, trap_errors=True, login=use_login_shell)

getlogger().info(
f'Detecting topology of remote partition {part.fullname!r}: '
Expand Down