[bugfix] Fix expected OpenMP versions for Dom #350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Distinguish daint and dom openmp versions after dom maintenance. * Refactor to new check syntax.
Contributor
Author
|
@jgphpc Here are the
Thanks. What i wanted wasthe version of the compilers:
|
vkarak
requested changes
Jul 10, 2018
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
Apart of my individual comments, my only concern is that this test will be failing as soon as Daint is upgraded.
|
|
||
| def _get_checks(**kwargs): | ||
| return [JacobiNoToolHybrid(lang, **kwargs) for lang in ('C', 'C++', 'F90')] | ||
| environ_name = self.current_environ.name |
Contributor
There was a problem hiding this comment.
Move this up and use it also for setting the ompversion_key.
| import reframe as rfm | ||
| import reframe.utility.sanity as sn | ||
| from reframe.core.fields import ScopedDict | ||
| from reframe.core.pipeline import RegressionTest |
Contributor
There was a problem hiding this comment.
Remove this and access RegressionTest from rfm.
| @@ -1,15 +1,17 @@ | |||
| import os | |||
Contributor
Author
There was a problem hiding this comment.
It is needed for the path join according to the language.
|
|
||
| self.name = 'jacobi_%s' % lang.replace('+', 'p') | ||
| self.language = lang | ||
| self.descr = '%s check' % lang |
Contributor
There was a problem hiding this comment.
I would put descr just after name.
Contributor
Author
|
@vkarak once daint is upgraded we can put the newer versions to it as well. |
vkarak
approved these changes
Jul 10, 2018
vkarak
changed the title
Contributor
|
@jenkins-cscs retry dom |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Distinguish daint and dom openmp versions after dom maintenance.
Refactor to new check syntax.