[test] Adapt Paraview check for PE 18.07 #401
Conversation
* Adapt to new regression test syntax. * Make a change in `coloredSphere.py` to load different python modules depending on the ParaView version.
vkarak
changed the title
|
@jenkins-cscs retry all |
| self.executable_opts = ['coloredSphere.py'] | ||
|
|
||
| # Needed in order to swap from the default version of gcc | ||
| self.pre_run = ['module swap gcc/6.2.0 gcc/7.1.0'] |
There was a problem hiding this comment.
This is not too portable. I suggest specifying gcc/7.1.0 in self.modules. Then ReFrame will generate the necessary commands.
There was a problem hiding this comment.
Specifying into the modules generated the following:
module load daint-gpu
module unload PrgEnv-cray
module load PrgEnv-gnu
module unload PrgEnv-cray
module unload gcc
module load gcc/7.1.0
module unload PrgEnv-cray
module unload gcc
module load ParaView
which unloads again gcc before loading Paraview.
There was a problem hiding this comment.
It seems that sth is wrong with the module command generation. This looks like related to #59. Can you add a note before pre_run referring to this issue?
Codecov Report
@@ Coverage Diff @@
## master #401 +/- ##
==========================================
+ Coverage 91.08% 91.15% +0.06%
==========================================
Files 68 68
Lines 8247 8300 +53
==========================================
+ Hits 7512 7566 +54
+ Misses 735 734 -1
Continue to review full report at Codecov.
|
| # NOTE: This is needed in order to swap from the default | ||
| # version of gcc until issue #59 is fixed. Then it should | ||
| # be moved to the `self.modules` definition. | ||
| self.pre_run = ['module swap gcc/6.2.0 gcc/7.1.0'] |
There was a problem hiding this comment.
After merging with master, this workaround should not be needed.
|
@jenkins-cscs retry daint |
Adapt to new regression test syntax.
Make a change in
coloredSphere.pyto load different python modulesdepending on the ParaView version.
Closes #381.