[test] Adapt the Boost Python test for PE 18.07 #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapt the test for PE 18.07. * Adapt for the newer Boost version, 1.67.
teojgo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #408 +/- ##
==========================================
- Coverage 91.22% 91.21% -0.02%
==========================================
Files 70 70
Lines 8582 8582
==========================================
- Hits 7829 7828 -1
- Misses 753 754 +1
Continue to review full report at Codecov.
|
vkarak
approved these changes
Jul 26, 2018
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm, except for my comment about the valid programming environments.
| self.valid_systems = ['daint:mc', 'daint:gpu', 'dom:mc', 'dom:gpu'] | ||
| self.valid_prog_environs = ['PrgEnv-cray'] | ||
| python_major_version = python_version.split('.')[0] | ||
| self.valid_prog_environs = ['PrgEnv-gnu'] |
Contributor
There was a problem hiding this comment.
Was it wrong previously that used PrgEnv-cray?
Contributor
Author
There was a problem hiding this comment.
Yes it was wrong. Nevertheless the boost module loaded PrgEnv-gnu, and now that we have the build system I can see the conflict in the .err file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the test for PE 18.07.
Adapt for the newer Boost version, 1.67.
Closes #366