[test] Adapt haswell_fma to buildsystems style #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #415 +/- ##
======================================
Coverage 91.2% 91.2%
======================================
Files 70 70
Lines 8582 8582
======================================
Hits 7827 7827
Misses 755 755Continue to review full report at Codecov.
|
Contributor
Author
|
@jenkins-cscs retry all |
vkarak
requested changes
Aug 9, 2018
| self.current_environ.cflags = '-O3 -S' | ||
| self.current_environ.cxxflags = '-O3 -S' | ||
| self.current_environ.fflags = '-O3 -S' | ||
| def setup(self, partition, environ, **job_opts): |
Contributor
There was a problem hiding this comment.
You don't need to override setup() here, since you are changing behaviour based on the system.
Contributor
Author
There was a problem hiding this comment.
I need it because the flags change based on the environment.
vkarak
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #392