[test] Adapt ddt regression test to PE 18.07 #425
Conversation
* Adapt to build systems. * Adapt to new syntax. * Remove unused Makefiles * Add build dependencies in the F90 Makefile in order to make the Fortran modules available.
* Revert removal of `Makefile`. * Remove `Makefile_ddt` from `src` and all programming languages. * Restrict `max_concurrency` in case of Fortran.
Codecov Report
@@ Coverage Diff @@
## master #425 +/- ##
=========================================
- Coverage 91.21% 91.2% -0.02%
=========================================
Files 70 70
Lines 8585 8585
=========================================
- Hits 7831 7830 -1
- Misses 754 755 +1
Continue to review full report at Codecov.
|
| self.extension = extension | ||
| self.makefile = 'Makefile' | ||
| self.build_system = 'Make' | ||
| self.build_system.makefile = 'Makefile' |
There was a problem hiding this comment.
Makefile is the default. Why do you set it?
| # 'PrgEnv-pgi': ' -O2 -mp' | ||
| } | ||
| self.flags = ' -g' | ||
| self.flags = ['-g'] |
There was a problem hiding this comment.
Why don't you put directly the -g flag inside the self.prgenv_flags. I think the code would be more readable.
| self.ddt_options = [] | ||
| self.keep_files = ['ddtreport.txt'] | ||
|
|
||
| def _set_compiler_flags(self): |
There was a problem hiding this comment.
Is there a reason for this function?
| ] | ||
|
|
||
| self.flags += ['-DUSE_MPI'] | ||
| self.flags += ['-D_CSCS_ITMAX=5'] |
There was a problem hiding this comment.
If you set self.build_systems.cppflags, the trick with the flags attribute won't be needed.
|
|
||
| if self.current_system.name == 'kesch': | ||
| arch = 'sm_37' | ||
| self.flags += ['-lm', '-lcudart'] |
There was a problem hiding this comment.
Similarly here, you should set the ldflags of the build system.
|
|
||
| self.flags += ['-DUSE_MPI'] | ||
| self.flags += ['-D_CSCS_ITMAX=5'] | ||
| self.build_system.cflags = ['-DUSE_MPI', '-D_CSCS_ITMAX=5'] |
There was a problem hiding this comment.
These are cppflags (i.e., preprocessor flags). Here, you will only set the CFLAGS in the Makefile invocation.
There was a problem hiding this comment.
But the Makefile has to use them during compilation right?
|
@teojgo There seems to be a bug in the test for Kesch. |
4 participants
Adapt to build systems.
Adapt to new syntax.
Remove unused Makefiles
Add build dependencies in the F90 Makefile in order to
make the Fortran modules available.
Closes #368
Addresses #397