[test] Adapt trilinos regression test to PE18.08 and build systems #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teojgo
changed the title
vkarak
requested changes
Sep 19, 2018
| # Removed CRAY env in dynamic because of CrayBug/809265 | ||
| if linkage == 'dynamic': | ||
| # NOTE: PrgEnv-cray in dynamic does not work because of CrayBug/809265 | ||
| # PrgEnv-cray seg faults for cray-trilinos/12.12.1.1 |
Contributor
There was a problem hiding this comment.
I don't think this note has to be in this test, since you are not doing anything special for it, do you? If the bug is fixed, the test will pass automatically. I suggest putting this note in the PR description instead.
| self.build_system = 'SingleSource' | ||
| self.build_system.ldflags = ['-%s' % linkage] | ||
| self.build_system.cppflags = ['-DHAVE_MPI', '-DEPETRA_MPI'] | ||
| self.build_system.cxxflags = ['-lparmetis'] |
| self.sourcepath = 'example_AmesosFactory_HB.cpp' | ||
| input_file = os.path.join(self.current_system.resourcesdir, | ||
| 'Trilinos', 'trilinos_compile_run.rua') | ||
| self.executable_opts = input_file.split() |
Contributor
There was a problem hiding this comment.
This split here is kind of strange, isn't it? I don't think it's needed: [input_file] should be fine.
Codecov Report
@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 70 70
Lines 8784 8784
=======================================
Hits 8024 8024
Misses 760 760Continue to review full report at Codecov.
|
vkarak
requested changes
Sep 19, 2018
vkarak
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test fails for
PrgEnv-craysince the executable gibes a segmentation fault for cray-trilinos/12.12.1.1Fixes #385
Fixes #363