[test] Promote DGEMM to a multi-node check #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorusu
changed the title
victorusu
force-pushed
the
checks/flex-dgemm
branch
from
1863bbd to
3f89a5a
Compare
vkarak
requested changes
Oct 19, 2018
victorusu
force-pushed
the
checks/flex-dgemm
branch
from
54e999a to
95af8a8
Compare
teojgo
reviewed
Nov 20, 2018
teojgo
reviewed
Nov 20, 2018
teojgo
requested changes
Nov 20, 2018
Contributor
|
@victorusu Another important thing is to move this test to the private ones. |
Contributor
Author
|
why? |
Contributor
The flexible tests should be in the private repository. They cannot be tested also by the ci. |
vkarak
requested changes
Nov 20, 2018
vkarak
requested changes
Nov 20, 2018
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
==========================================
- Coverage 91.57% 91.57% -0.01%
==========================================
Files 72 72
Lines 8962 8980 +18
==========================================
+ Hits 8207 8223 +16
- Misses 755 757 +2
Continue to review full report at Codecov.
|
teojgo
requested changes
Nov 29, 2018
vkarak
requested changes
Dec 1, 2018
* Correct the reference values for daint/dom. * Minor code style fixes
|
Hello @victorusu! Thanks for updating the PR.
Comment last updated on December 05, 2018 at 15:18 Hours UTC |
vkarak
requested changes
Dec 6, 2018
vkarak
reviewed
Dec 6, 2018
vkarak
approved these changes
Dec 6, 2018
Contributor
|
@jenkins-cscs retry dom |
1 similar comment
Contributor
|
@jenkins-cscs retry dom |
teojgo
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470.
Fixes #101.