Skip to content

Conversation

@rsarm
Copy link
Contributor

@rsarm rsarm commented Nov 6, 2018

@rsarm rsarm added this to the https://github.com/eth-cscs/reframe-tests/milestone/9 milestone Nov 6, 2018
@rsarm rsarm self-assigned this Nov 6, 2018
@rsarm rsarm requested a review from vkarak November 6, 2018 15:53
@vkarak vkarak changed the title [test] Update maintenance performance numbers for CP2K [test] Update CP2K test Nov 6, 2018
@vkarak vkarak modified the milestones: https://github.com/eth-cscs/reframe-tests/milestone/9, ReFrame sprint 2018w44 Nov 6, 2018
Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest updating this check to new style. Currently, it's old stylish. You should remove the production and maintenance subclasses and replace them with a variant argument. Here's an outline:

@rfm.parameterized_test(['prod'], ['maint'])
class Cp2kGPUCheck(rfm.RunOnlyRegressionTest):
    def __init__(self, variant):
        if variant == 'prod':
            ...

@rfm.parameterized_test(['prod'], ['maint'])
class Cp2kCPUCheck(Cp2kCPUCheck):
    def __init__(self, variant):
        ...

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for a minor comment.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the reframe.out file.

@vkarak vkarak closed this Nov 12, 2018
@vkarak vkarak reopened this Nov 12, 2018
@vkarak
Copy link
Contributor

vkarak commented Nov 12, 2018

@jenkins-cscs retry daint

@codecov-io
Copy link

codecov-io commented Nov 12, 2018

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files          72       72           
  Lines        8954     8954           
=======================================
  Hits         8199     8199           
  Misses        755      755

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce8029...52e7dc2. Read the comment docs.

@vkarak vkarak merged commit 67c9363 into reframe-hpc:master Nov 12, 2018
@rsarm rsarm deleted the checks/cp2k-perf branch November 26, 2019 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants