-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Update CP2K test #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest updating this check to new style. Currently, it's old stylish. You should remove the production and maintenance subclasses and replace them with a variant argument. Here's an outline:
@rfm.parameterized_test(['prod'], ['maint'])
class Cp2kGPUCheck(rfm.RunOnlyRegressionTest):
def __init__(self, variant):
if variant == 'prod':
...
@rfm.parameterized_test(['prod'], ['maint'])
class Cp2kCPUCheck(Cp2kCPUCheck):
def __init__(self, variant):
...
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for a minor comment.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the reframe.out file.
|
@jenkins-cscs retry daint |
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 91.56% 91.56%
=======================================
Files 72 72
Lines 8954 8954
=======================================
Hits 8199 8199
Misses 755 755Continue to review full report at Codecov.
|
Closes https://github.com/eth-cscs/reframe-tests/issues/30