[bugfix] Check if 'UnavailableNodes' are down to cancel job #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use scontrol to retrieve the state of the nodes reported as unavailable and cancel the job if they are down. * Add methods `in_state` and `is_down` to `SlurmNode` class. * Add unittests for the above methods.
vkarak
requested changes
Nov 26, 2018
vkarak
requested changes
Dec 1, 2018
reframe/core/schedulers/slurm.py
Outdated
| self.in_state(s) for s in ['DOWN', 'DRAIN', 'MAINT', 'NO_RESPOND']) | ||
| return bool({'DOWN', 'DRAIN', 'MAINT', 'NO_RESPOND'} & self._states) | ||
|
|
||
| def in_state(self, state): |
Contributor
There was a problem hiding this comment.
I don't think you need this anymore. If you want to use it, the only place is the is_available() method, which could call this one.
vkarak
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
scontrolto retrieve the state of the nodes reportedas unavailable and cancel the job if they are down.
Add methods
in_stateandis_downtoSlurmNodeclass.Add unit tests for the above methods.
Fixes #303