-
Notifications
You must be signed in to change notification settings - Fork 117
[test] Add flexible HPCG test #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I test this patch? |
Codecov Report
@@ Coverage Diff @@
## master #604 +/- ##
==========================================
+ Coverage 91.62% 91.64% +0.02%
==========================================
Files 72 72
Lines 9191 9191
==========================================
+ Hits 8421 8423 +2
+ Misses 770 768 -2
Continue to review full report at Codecov.
|
victorusu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sebkelle1, The checks look great to me, but I have just a few questions related to extending to other systems. And a philosophical question about when we should consider a test to failure performance.
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. It's in a good shape. I have only a couple of minor comments. The test should also be placed under cscs-checks/microbenchmarks.
|
@sebkelle1 Can you address the review comments so that we can merge this? |
|
Hello @sebkelle1, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on January 11, 2019 at 10:17 Hours UTC |
vkarak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a couple of formatting issues reported by pep8speaks. I have suggested a styling in one of those. I have also one question regarding the base test. See my individual comments.
|
@teojgo @victorusu Could you please have a look and approve this PR? |
|
@jenkins-cscs retry daint kesch |
Added checks for two HPCG implementations.
Fixes #550.