Skip to content

Conversation

@sekelle
Copy link
Contributor

@sekelle sekelle commented Nov 27, 2018

Added checks for two HPCG implementations.

Fixes #550.

@jenkins-cscs
Copy link
Collaborator

Can I test this patch?

@codecov-io
Copy link

codecov-io commented Nov 27, 2018

Codecov Report

Merging #604 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
+ Coverage   91.62%   91.64%   +0.02%     
==========================================
  Files          72       72              
  Lines        9191     9191              
==========================================
+ Hits         8421     8423       +2     
+ Misses        770      768       -2
Impacted Files Coverage Δ
reframe/core/config.py 84.34% <0%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cc65c...4ac9f09. Read the comment docs.

@vkarak vkarak changed the title Checks/hpcg flexible [test] Add flexible HPCG test Nov 27, 2018
@vkarak vkarak added this to the Upcoming sprint milestone Nov 27, 2018
Copy link
Contributor

@victorusu victorusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebkelle1, The checks look great to me, but I have just a few questions related to extending to other systems. And a philosophical question about when we should consider a test to failure performance.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. It's in a good shape. I have only a couple of minor comments. The test should also be placed under cscs-checks/microbenchmarks.

@vkarak vkarak removed this from the ReFrame sprint 2018w48 milestone Dec 3, 2018
@vkarak
Copy link
Contributor

vkarak commented Dec 17, 2018

@sebkelle1 Can you address the review comments so that we can merge this?

@pep8speaks
Copy link

pep8speaks commented Dec 18, 2018

Hello @sebkelle1, Thank you for updating!

Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide

Comment last updated on January 11, 2019 at 10:17 Hours UTC

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a couple of formatting issues reported by pep8speaks. I have suggested a styling in one of those. I have also one question regarding the base test. See my individual comments.

@vkarak
Copy link
Contributor

vkarak commented Jan 9, 2019

@teojgo @victorusu Could you please have a look and approve this PR?

@vkarak
Copy link
Contributor

vkarak commented Jan 11, 2019

@jenkins-cscs retry daint kesch

@victorusu victorusu merged commit 4802c07 into reframe-hpc:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants