Skip to content

[bugfix] Fix deadlock in the flexible task allocation when the node list output is too large #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2018
Merged

[bugfix] Fix deadlock in the flexible task allocation when the node list output is too large #614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f022ed2
Fix blocking subprocess when output is large
Nov 29, 2018
335433c
Merge branch 'master' into bugfix/subprocess_communicate
vkarak Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions reframe/utility/os_ext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@
def run_command(cmd, check=False, timeout=None, shell=False):
try:
proc = run_command_async(cmd, shell=shell, start_new_session=True)
proc.wait(timeout=timeout)
proc_stdout, proc_stderr = proc.communicate(timeout=timeout)
except subprocess.TimeoutExpired as e:
os.killpg(proc.pid, signal.SIGKILL)
raise SpawnedProcessTimeout(e.cmd,
proc.stdout.read(),
proc.stderr.read(), timeout) from None
proc.stdout,
proc.stderr, timeout) from None

completed = subprocess.CompletedProcess(args=shlex.split(cmd),
returncode=proc.returncode,
stdout=proc.stdout.read(),
stderr=proc.stderr.read())
stdout=proc_stdout,
stderr=proc_stderr)

if check and proc.returncode != 0:
raise SpawnedProcessError(completed.args,
Expand Down