[ci] Enable pep8speaks for code style checking in the repository #626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Automatically check for ReFrame Coding Style violations.
|
Hello @teojgo, Thank you for updating!
Do see the ReFrame Coding Style Guide Comment last updated on December 04, 2018 at 16:59 Hours UTC |
teojgo
changed the title
vkarak
requested changes
Dec 4, 2018
Contributor
vkarak
left a comment
vkarak
left a comment
There was a problem hiding this comment.
lgtm! Can you also do the change proposed by the pep8speaks?
Contributor
|
@teojgo Why is this WIP? |
Contributor
Author
|
@vkarak I need to recheck what it prints when there are no errors since now it should be updated after I fixed the coding style. |
Contributor
|
@teojgo The message seems to be updated. Looks good, I think! |
vkarak
approved these changes
Dec 4, 2018
teojgo
changed the title
Contributor
Author
|
@vkarak it's ok to merge and we can make any changes in the future. |
vkarak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167