Skip to content

Conversation

@kraushm
Copy link
Contributor

@kraushm kraushm commented Dec 14, 2018

Creating the option --show-config listing the system configuration in a readable format.

Closes #306
Closes #215

@vkarak vkarak changed the title [WIP]: add show-config option [WIP] [feat] Add command line options for showing the system and environments configuration Dec 14, 2018
@codecov-io
Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #633 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage    91.5%   91.59%   +0.09%     
==========================================
  Files          72       72              
  Lines        9009     9058      +49     
==========================================
+ Hits         8244     8297      +53     
+ Misses        765      761       -4
Impacted Files Coverage Δ
reframe/core/systems.py 87.7% <100%> (+2.58%) ⬆️
unittests/test_cli.py 96.3% <100%> (+0.27%) ⬆️
reframe/core/environments.py 90.38% <100%> (+0.38%) ⬆️
reframe/frontend/cli.py 81.01% <100%> (+1.16%) ⬆️
reframe/core/runtime.py 88.11% <100%> (+1.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c17a0d...b109895. Read the comment docs.

@vkarak vkarak self-assigned this Dec 21, 2018
- New options added: `--show-config` and `--show-config-env ENV`.
- Unit tests added as well
@vkarak vkarak requested review from teojgo and victorusu December 21, 2018 13:19
@vkarak
Copy link
Contributor

vkarak commented Dec 21, 2018

I finalized the implementation. Output is YAML-like. I added also an option to show the environment configuration. Still to do is to update the documentation.

@vkarak vkarak changed the title [WIP] [feat] Add command line options for showing the system and environments configuration [feat] Add command line options for showing the system and environments configuration Dec 21, 2018
@vkarak
Copy link
Contributor

vkarak commented Dec 21, 2018

Documentation updated.

@vkarak
Copy link
Contributor

vkarak commented Jan 8, 2019

@teojgo @victorusu Can you please review this so that we can merge it?

@vkarak vkarak merged commit 0f33427 into reframe-hpc:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants