Skip to content

[bugfix] Fix bug in variable names in Slurm backend #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2019
Merged

[bugfix] Fix bug in variable names in Slurm backend #639

merged 1 commit into from
Jan 8, 2019

Conversation

@teojgo
Copy link
Contributor

@teojgo teojgo commented Jan 8, 2019

Fixes #636

@teojgo teojgo self-assigned this Jan 8, 2019
@teojgo teojgo requested review from rsarm and vkarak January 8, 2019 10:09
@codecov-io
Copy link

codecov-io commented Jan 8, 2019

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          72       72           
  Lines        9142     9142           
=======================================
  Hits         8367     8367           
  Misses        775      775
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 60.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b692a...a101742. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jan 8, 2019 •
edited
Loading

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   91.52%   91.52%           
=======================================
  Files          72       72           
  Lines        9142     9142           
=======================================
  Hits         8367     8367           
  Misses        775      775
Impacted Files Coverage Δ
reframe/core/schedulers/slurm.py 60.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b692a...a101742. Read the comment docs.

@vkarak vkarak changed the title [bugfix] Fix bugs in variable naming [bugfix] Fix bug in variable names in Slurm backend Jan 8, 2019
@vkarak vkarak merged commit f729cb7 into reframe-hpc:master Jan 8, 2019
@teojgo teojgo deleted the bugfix/undefined_variable_slurm branch January 18, 2019 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkarak vkarak vkarak approved these changes

@rsarm rsarm rsarm approved these changes

Assignees

@teojgo teojgo

Labels

bugfix prio: important

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@teojgo @codecov-io @vkarak @rsarm