[bugfix] Fix crash in failure report when test is killed due to timeout #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Calling the `communicate` method returns a tuple of `_io.TextIOWrapper` objects if the subprocess has timed out. Therefore, using the `__str__` method of the `SpawnedProcessTimeout` exception raises a `TypeError`. * The `read` method shoud be used to retrieve the string of the `_io.TextIOWrapper` objects.
|
Hello @teojgo, Thank you for updating! Cheers! There are no PEP8 issues in this Pull Request!Do see the ReFrame Coding Style Guide Comment last updated on February 18, 2019 at 15:00 Hours UTC |
Contributor
Author
|
@jenkins-cscs retry daint |
vkarak
requested changes
Feb 15, 2019
vkarak
changed the title
vkarak
changed the title
vkarak
approved these changes
Feb 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #680 +/- ##
==========================================
- Coverage 91.87% 91.85% -0.03%
==========================================
Files 77 77
Lines 9444 9445 +1
==========================================
- Hits 8677 8676 -1
- Misses 767 769 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix boils down to fixing the string conversion of
SpawnedProcessTimeout:Calling the
communicatemethod returns a tuple of_io.TextIOWrapperobjects if the subprocess has timed out.Therefore, using the
__str__method of theSpawnedProcessTimeoutexception raises a
TypeError.The
readmethod shoud be used to retrieve the string of the_io.TextIOWrapperobjects.Fixes #658