Skip to content

Conversation

@vkarak
Copy link
Contributor

@vkarak vkarak commented Feb 18, 2019

  • Extend expandvars() to support command substitutions.
  • Replace almost all usages of os.path.expandvars() with our version.

Fixes #682.

I still need to update a bit the documentation. I believe this is a feature rather than a bugfix.

- Extend `expandvars` to support command substitutions.
- Replace almost all usages of `os.path.expandvars` with our version.
@vkarak vkarak added this to the ReFrame sprint 2019w07 milestone Feb 18, 2019
@vkarak vkarak self-assigned this Feb 18, 2019
@vkarak vkarak requested a review from teojgo February 18, 2019 12:17
@codecov-io
Copy link

codecov-io commented Feb 18, 2019

Codecov Report

Merging #683 into master will increase coverage by 0.05%.
The diff coverage is 94.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
+ Coverage   91.82%   91.87%   +0.05%     
==========================================
  Files          77       77              
  Lines        9403     9444      +41     
==========================================
+ Hits         8634     8677      +43     
+ Misses        769      767       -2
Impacted Files Coverage Δ
reframe/core/environments.py 88.67% <100%> (ø) ⬆️
reframe/utility/os_ext.py 90.25% <100%> (+0.6%) ⬆️
reframe/frontend/cli.py 81.01% <100%> (ø) ⬆️
unittests/test_utility.py 99.03% <100%> (+0.06%) ⬆️
reframe/core/config.py 84.48% <57.14%> (+1.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4d71e...38449d7. Read the comment docs.

@vkarak vkarak merged commit 8b7d1b5 into reframe-hpc:master Feb 18, 2019
@vkarak vkarak deleted the feat/expandvars-with-cmd-subst branch February 18, 2019 14:10
@teojgo teojgo added this to the ReFrame sprint 2019w07 milestone Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR #635 has broken Kesch environments

3 participants